Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the bound duals in the AMPL solution using suffixes #47

Closed
cvanaret opened this issue Oct 26, 2024 · 4 comments
Closed

Write the bound duals in the AMPL solution using suffixes #47

cvanaret opened this issue Oct 26, 2024 · 4 comments
Assignees

Comments

@cvanaret
Copy link
Owner

At the moment, the call to ASL's write_sol_ASL writes the primal solution and the constraint duals in the .sol file. The bound duals should also be written using suffixes (see ASL documentation pp 20-22).
Reported by @odow.

@cvanaret cvanaret self-assigned this Oct 26, 2024
@cvanaret cvanaret added the AMPL label Oct 26, 2024
@cvanaret
Copy link
Owner Author

cvanaret commented Oct 26, 2024

Implemented in commit dd77f37.
The suffixes are lower_bound_duals and upper_bound_duals.

@odow
Copy link
Contributor

odow commented Oct 26, 2024

Nice!

Currently, we've got these strings hard-coded into MOI:
https://github.com/jump-dev/MathOptInterface.jl/blob/ee313beac6e9853fe1ae3bab79befa0f51a27886/src/FileFormats/NL/sol.jl#L348-L364

So I guess we should make the sol reader more flexible as to how it parses suffixes.

Alternatively, we could make Uno call them ipopt_zL_out and ipopt_zU_out... but I don't know if that is a good or bad idea. I agree that the suffix stuff in ASL is horrible.

@cvanaret
Copy link
Owner Author

cvanaret commented Oct 26, 2024

Making the sol reader more flexible would be advantageous, although I'm unsure which convention we could use.
Using the IPOPT suffixes in Uno would be a bit weird. Would it be an option - as a quick fix - to add a command line in Uno_jll's build_tarballs.jl the definition of Uno_jll.amplexe to replace Uno's suffixes with IPOPT's suffixes in the .sol file?

@odow
Copy link
Contributor

odow commented Oct 27, 2024

I'll fix this in MOI jump-dev/MathOptInterface.jl#2566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants