Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click is used for "Delete point" and for "Fit". It isn't conveniently. #283

Closed
bsekachev opened this issue Jan 18, 2019 · 6 comments
Assignees
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release enhancement New feature or request
Milestone

Comments

@bsekachev
Copy link
Member

Often an user wants delete a point from a poly shape, but instead an user fits the player screen.

@bsekachev bsekachev added the enhancement New feature or request label Jan 18, 2019
@bsekachev bsekachev added this to the 0.4.0 - Beta milestone Jan 18, 2019
@bsekachev bsekachev added the Easy to fix The issue is easy to fix and probably it will be release in a next minor release label Jan 18, 2019
@nmanovic
Copy link
Contributor

Need to collect statistics how often we use "fit" feature (add logs). Need to find another shortcut for one of them.

@ajaysjournal
Copy link
Contributor

What is "fit" feature? I am trying to reproduce this issue -

Steps:

  1. Create a polygon(works)
  2. Delete the points on the Polygon by double click(works)

So, as an enhancement to CVAT, first, we need to add logs to fit feature? Based on fit feature usage we can provide another shortcut?

If you explain fit feature, I think I can add the logs to it. Any advice on this enhancement ?

@bsekachev
Copy link
Member Author

@ajayramezh
"Fit Image" feature is auto resize of an image in such way that it fully displayed in the player.
The feature has the same shortcut (double click) as the delete point feature. It is inconvenient due to possible misses by points.
Log for the feature has been already added.

@bsekachev
Copy link
Member Author

In React UI you need to hold 'Ctrl' to delete a point.
Fitting doesn't work when 'Ctrl' pressed.
So, issue is expected to be fixed, but let's get feedback from DA team.

@nmanovic nmanovic assigned ActiveChooN and unassigned bsekachev Mar 21, 2020
@nmanovic nmanovic modified the milestones: 1.0.0 - Beta, 1.0.0 - Alpha Mar 21, 2020
@nmanovic
Copy link
Contributor

The problem was fixed. Now we have context menu to delete a point. @ActiveChooN , please reopen the issue if I'm wrong.

@bsekachev
Copy link
Member Author

@nmanovic

There always was a context menu in CVAT.
The issue is about double click is used in two scenarios.
But in new UI it also has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants