Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin node version? #3

Closed
jakelowen opened this issue Nov 19, 2018 · 3 comments · Fixed by #4
Closed

unpin node version? #3

jakelowen opened this issue Nov 19, 2018 · 3 comments · Fixed by #4
Labels
chore Technical debt, housekeeping... the fun stuff

Comments

@jakelowen
Copy link

Great package! Thanks.

Is there any particular reason you've pinned your node engine at 10.6.0?
I'm currently developing on 11.1.0 and when I install this package I get a warning:

error datasource-sql@0.1.2: The engine "node" is incompatible with this module. Expected version "10.6.0". Got "11.1.0"
error Found incompatible module

It would be great to avoid that warning on an install.
@cvburgess
Copy link
Owner

cvburgess commented Nov 20, 2018 •
edited
Loading

Nope! I should probably change it to >= 10.x based on node.green

@cvburgess cvburgess added the chore Technical debt, housekeeping... the fun stuff label Nov 20, 2018
@cvburgess cvburgess mentioned this issue Nov 20, 2018
Merged
@cvburgess
Copy link
Owner

@jakelowen does #4 fix your issue?

@cvburgess
Copy link
Owner

@jakelowen v0.1.3 is published - hope it helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Technical debt, housekeeping... the fun stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.1.3 cvburgess/SQLDataSource
2 participants
@cvburgess @jakelowen