Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Issue 6 - Improve code quality #3

Open
cverges opened this issue Aug 27, 2013 · 0 comments
Open

GCP Issue 6 - Improve code quality #3

cverges opened this issue Aug 27, 2013 · 0 comments

Comments

@cverges
Copy link
Owner

cverges commented Aug 27, 2013

Reported by legege, Nov 18, 2009
A basic list of things to do that would help to improve the quality of this
library:

  • Meaningful JavaDoc
  • Standard: code formating, avoid _ in method names, ...
  • Remove dead code and code that is no longer used (comments)
  • Package name: com.googlecode.expect4j
  • Avoid public/package attributes
  • Avoid utils class (ExpectUtils)

Nov 18, 2009 #1 legege
I've refactored this library to remove the dependency on the tcl library. Of course, this removes the Expect
script tcl execution feature.

I've also completed basic code quality improvements. There are still a lot to do (e.g. break down the expect
method in Expect4J.. this method is unreadable). Unit tests are not deterministic (sometimes fails), exactly like
the HEAD version.

If the community is interested, I can commit this into a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant