Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC practice 2 #112

Closed
3 tasks
cvvergara opened this issue Apr 26, 2017 · 0 comments
Closed
3 tasks

GSoC practice 2 #112

cvvergara opened this issue Apr 26, 2017 · 0 comments
Labels
Milestone

Comments

@cvvergara
Copy link
Owner

cvvergara commented Apr 26, 2017

important: DO NOT START THIS TASK until I finish merging the other PR and generate the documentation

The file include/pgr_types.h still has 3 structures that need to be in a separate file
One per person:

  • pgr_contracted_blob; - Ankur
    • will give you an opportunity to read a little about the contraction code
  • path_element_t; - Mao
  • pgr_path_t; - Vid

Way to work:

  • depart from develop (As always create a new branch to work on)
  • "imitate" other include files.
  • Create the include/c_types/struct_name.h The name of the file should correspond as the name of the struct, use lower case)
  • copy from pgr_types.h the sctructure in question.
    • dont forget to add the licence
  • compile locally
    • the compiler is your friend, it will complain in the file you need to modify
    • got to the file and change:
#include "include/c_types/pgr_types"

to

#include "include/c_types/struct_name.h"

until it passes.
lint the header

sh tools/scripts/code_checker.sh h

commit push and verify that works on travis & appveyor and make the PR

special task for Ankur

Please read: #119

So this one is for you: pgr_contracted_blob -> Contracted_rt

to rename a file in git:

git mv pgr_contracted_blob.h contracted_rt.h

edit the file and change pgr_contracted_blob to Contracted_rt
again, let the compiler be your friend, let it figure out where in the code you need to change code

@cvvergara cvvergara added this to the 2.5-dev milestone May 3, 2017
@cvvergara cvvergara changed the title pending task on 2.5 before merge GSoC practice #2 May 17, 2017
@cvvergara cvvergara changed the title GSoC practice #2 GSoC practice 2 May 17, 2017
@cvvergara cvvergara added the GSoC label May 22, 2017
@cvvergara cvvergara reopened this May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant