From 9aea8f6436c1b961dfed7d7c06f670bc34b140db Mon Sep 17 00:00:00 2001
From: Akshay Agrawal <akshaykagrawal7@gmail.com>
Date: Sun, 20 Nov 2022 09:02:26 -0800
Subject: [PATCH] Fix 3d plotting (#70)

Creating Axes3D directly silently fails in newer versions of matplotlib.
Use the current recommended method of adding a 3d projection to a figure
instead.
---
 pymde/experiment_utils.py | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/pymde/experiment_utils.py b/pymde/experiment_utils.py
index 940bb09..889adbe 100644
--- a/pymde/experiment_utils.py
+++ b/pymde/experiment_utils.py
@@ -150,7 +150,6 @@ def _is_discrete(dtype):
 def _plot_3d(
     X, color_by, cmap, colors, edges, s, background_color, figsize, lim
 ):
-    from mpl_toolkits.mplot3d import Axes3D
 
     if isinstance(X, torch.Tensor):
         X = X.cpu().numpy()
@@ -159,7 +158,7 @@ def _plot_3d(
     shadowcolor = "gainsboro"
 
     fig = plt.figure(figsize=figsize)
-    ax = Axes3D(fig)
+    ax = fig.add_subplot(projection='3d')
 
     x, y, z = X[:, 0], X[:, 1], X[:, 2]
 
@@ -196,27 +195,26 @@ def _plot_3d(
     ax.set_zlim(lim)
 
     if edges is None:
-        ax.plot(
+        # shadows
+        ax.scatter(
             y,
             z,
-            "g+",
             zdir="x",
             zs=ax.axes.get_xlim3d()[0],
             c=shadowcolor,
             alpha=0.5,
             marker="o",
-            markersize=shadowsize,
+            s=shadowsize,
         )
-        ax.plot(
+        ax.scatter(
             x,
             y,
-            "k+",
             zdir="z",
             zs=ax.axes.get_zlim3d()[0],
             c=shadowcolor,
             alpha=0.5,
             marker="o",
-            markersize=shadowsize,
+            s=shadowsize,
         )
 
     if background_color is not None: