Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should "composer status" fail after successful patch? #573

Open
1 task done
azalea666 opened this issue May 3, 2024 · 2 comments
Open
1 task done

Should "composer status" fail after successful patch? #573

azalea666 opened this issue May 3, 2024 · 2 comments
Labels
documentation Solely about the documentation of the project.

Comments

@azalea666
Copy link

Verification

  • I have searched existing issues and discussions for my problem.

Which file do you have feedback about? (leave blank if not applicable)

No response

Feedback

i don't know if it's a bug or not, or misconfiguration, but after successfully applying two patches with the plugin, composer status reports "You have changes in the following dependencies: ... [lists packages changed by patch (or files if using -v)] ... Composer [status] failed, composer command failed: exit status 1. stderr="

is this the expected behavior?

@azalea666 azalea666 added the documentation Solely about the documentation of the project. label May 3, 2024
@cweagans
Copy link
Owner

cweagans commented May 3, 2024

Presently, yes, that's expected. I'd be open to a PR that makes composer status report things in a patch-aware way!

@azalea666
Copy link
Author

i think that would be cool. i ran into a similar problem with a plugin that does security hardening, removing documentation and test files and such, which makes "composer status" fail for the same reason

thanx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Solely about the documentation of the project.
Projects
None yet
Development

No branches or pull requests

2 participants