Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing artifacts on released file #2

Closed
marcgp opened this issue Jan 30, 2020 · 3 comments
Closed

Missing artifacts on released file #2

marcgp opened this issue Jan 30, 2020 · 3 comments
Labels
bug Something isn't working released on @next released

Comments

@marcgp
Copy link
Member

marcgp commented Jan 30, 2020

Describe the bug
the released zip file is missing mandatory artifacts.

To Reproduce
Please provide detailed steps to reproduce the error

  1. Download released zip file
  2. Extract it
  3. see missing config folder

Expected behavior
released zip should have the following files

root
  - <executable file>
  - <config dir>
    - config.sample.ini
    - <templates dir>
        - ScanSummary.html
@marcgp marcgp added the bug Something isn't working label Jan 30, 2020
@marcgp
Copy link
Member Author

marcgp commented Jan 30, 2020

changed release.sh in order to add missing artifacts. now release file should contain all proper information

@marcgp marcgp closed this as completed Jan 30, 2020
marcgp pushed a commit that referenced this issue Jan 30, 2020
fix(#2): add missing artifacts to released file
8081f80
marcgp pushed a commit that referenced this issue Jan 30, 2020
@semantic-release-bot
chore(release): 1.0.0-next.2 [skip ci]
81a7828 
# [1.0.0-next.2](v1.0.0-next.1...v1.0.0-next.2) (2020-01-30)

### Bug Fixes

* **#2:** add missing artifacts to released file ([8081f80](8081f80)), closes [#2](#2)
* **#3:** removed automatic versioning retrieving ([2efbd5c](2efbd5c)), closes [#3](#3)
@marcgp
Copy link
Member Author

marcgp commented Jan 30, 2020

ℹ️ℹ️ This issue has been fixed in Release v1.0.0-next.2

marcgp pushed a commit that referenced this issue Feb 6, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
ecb193d 
# 1.0.0 (2020-02-06)

### Bug Fixes

* **#2:** add missing artifacts to released file ([8081f80](8081f80)), closes [#2](#2)
* **#3:** removed automatic versioning retrieving ([2efbd5c](2efbd5c)), closes [#3](#3)
* **#5:** fixed ScanSummary template rendering issues ([328fd0d](328fd0d))

### Features

* **base:** add base functionality ([1716f85](1716f85))
* **base:** add Configuration and Logger services ([257c93a](257c93a))
* **base:** implemted retry mechanism on ScanSummary ([6379981](6379981))
@marcgp
Copy link
Member Author

marcgp commented Feb 6, 2020

ℹ️ℹ️ This issue has been fixed in Release v1.0.0

@marcgp marcgp added the released label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @next released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcgp