Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU compute for controllers #29

Merged
merged 2 commits into from
May 15, 2023

Conversation

omichel
Copy link
Member

@omichel omichel commented May 15, 2023

This PR enables the GPU compute inside the docker, so that controllers using GPU (Pytorch, TensorFlow, etc.) can get hardware acceleration as well.

@omichel omichel self-assigned this May 15, 2023
@omichel omichel added the enhancement New feature or request label May 15, 2023
@BenjaminDeleze
Copy link

It seems pretty useless to me as these variables are already set by Nvidia:

NVIDIA
docker

The only difference I see is the compute and compat32

@omichel
Copy link
Member Author

omichel commented May 15, 2023

Yes, but I believe compute is the key one needed for enabling GPU compute. And if we set only ENV NVIDIA_DRIVER_CAPABILITIES compute, I am afraid it will erase graphics and utility which are also needed.

@omichel
Copy link
Member Author

omichel commented May 15, 2023

But yes, we can probably remove ENV NVIDIA_VISIBLE_DEVICES all since it appears to be already set.

@BenjaminDeleze
Copy link

I found the list of capabilities:

Supported driver capabilities
compute: required for CUDA and OpenCL applications.
compat32: required for running 32-bit applications.
graphics: required for running OpenGL and Vulkan applications.
utility: required for using nvidia-smi and NVML.
video: required for using the Video Codec SDK.
display: required for leveraging X11 display.

So, yes it seems that we need compute

@omichel omichel merged commit 0cd9e3d into master May 15, 2023
@omichel omichel deleted the fix-enable-GPU-compute-acceleration-for-controllers branch May 15, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants