Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bounding sphere updates #6243

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Fix bounding sphere updates #6243

merged 7 commits into from
Jun 22, 2023

Conversation

stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Jun 21, 2023 •
edited
Loading

Address part of #6063:

  • fix bounding sphere visualization by activating the bounding sphere updates when node position or size is changed
  • fix camera recognition functionality by activating the bounding sphere updates when node position or size is changed
  • restore performance optimization in bounding sphere checks (see https://github.com/cyberbotics/webots-dev/pull/7570)
  • improve performance by skipping parent notification if bound space is already dirty

@stefaniapedrazzi stefaniapedrazzi added bug Something isn't working test suite Start the test suite labels Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b milestone Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi mentioned this pull request Jun 21, 2023
Closed
4 tasks
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review June 22, 2023 08:44
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner June 22, 2023 08:44
@BenjaminDeleze BenjaminDeleze self-requested a review June 22, 2023 09:08
BenjaminDeleze
BenjaminDeleze approved these changes Jun 22, 2023
View reviewed changes
Copy link

@BenjaminDeleze BenjaminDeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefaniapedrazzi stefaniapedrazzi merged commit 8968285 into master Jun 22, 2023
@stefaniapedrazzi stefaniapedrazzi deleted the fix-bounding-sphere-update branch June 22, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminDeleze BenjaminDeleze BenjaminDeleze approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels
bug Something isn't working test suite Start the test suite
Milestone
R2023b
Development

Successfully merging this pull request may close these issues.
2 participants
@stefaniapedrazzi @BenjaminDeleze