Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SUMO from Webots package #6245

Merged
merged 16 commits into from
Jun 23, 2023
Merged

Remove SUMO from Webots package #6245

merged 16 commits into from
Jun 23, 2023

Conversation

stefaniapedrazzi
Copy link
Member

As discussed in #6232, remove SUMO from the Webots package and document how to install it on the system.

@stefaniapedrazzi stefaniapedrazzi added the cleanup Any design, code, file or folder cleanup label Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b milestone Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi added the test distribution Start the distribution test label Jun 21, 2023
@stefaniapedrazzi stefaniapedrazzi mentioned this pull request Jun 21, 2023
Merged
@stefaniapedrazzi
Copy link
Member Author

I completed to remove the sumo files from the Webots package and development system, as well as updated the documentation to refer to the system SUMO installation.

Instructions to install SUMO are currently in these two files:

  • projects/default/controllers/sumo_supervisor/sumo_supervisor.py
  • docs/automobile/sumo-interface.md

Currently I tested the changes only on Linux.
We should also test them on macOS and Windows.

@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review June 21, 2023 16:01
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner June 21, 2023 16:01
@stefaniapedrazzi
Copy link
Member Author

@ygoumaz could you please check the changes for macOS?

@stefaniapedrazzi stefaniapedrazzi linked an issue Jun 22, 2023 that may be closed by this pull request
Missing dependencies for SUMO exporter #6217
Closed
@omichel
Copy link
Member

omichel commented Jun 23, 2023

I tested on Windows 11 and it works like a charm.

@ygoumaz
Copy link
Contributor

ygoumaz commented Jun 23, 2023

I have tested on all platforms and it works nicely. It is very easy to install and use the SUMO package, while decreasing the size of the Webots one.

@ygoumaz ygoumaz removed their request for review June 23, 2023 14:52
@ygoumaz ygoumaz requested a review from omichel June 23, 2023 14:52
omichel
omichel approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@omichel omichel removed the test distribution Start the distribution test label Jun 23, 2023
@ygoumaz ygoumaz merged commit a852ffb into master Jun 23, 2023
27 of 40 checks passed
@ygoumaz ygoumaz deleted the remove-sumo branch June 23, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz left review comments

@omichel omichel omichel approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels
cleanup Any design, code, file or folder cleanup
Milestone
R2023b
Development

Successfully merging this pull request may close these issues.

Missing dependencies for SUMO exporter
3 participants
@stefaniapedrazzi @omichel @ygoumaz