Fix right click macos #6251
Merged
Fix right click macos #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omichel
requested changes
Jun 23, 2023
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
BenjaminDeleze
added
test sources
omichel
added
test sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6244
This issue is specific to macOS.
Since the upgrade to Qt 6.4.3, the context menu (opened with a right click) of the 3d view was not closed when clicking in the 3d view, worse it was possible to open several context menus.
The issue was not fixed by upgrading to Qt 6.5.1.
Here is what I could gather on the issue:
mousePressEvent) but on the context menu is supposed to close it.Fix
Either we revert to 6.2.3 and wait for Qt to fix the bug (as I think that it is a Qt's bug). However, I saw nobody mention this bug for Qt 6 so far. This bug was present in some version of Qt and it took them several years to fix it (see here), so I am not sure it is the best idea.
Or we apply the fix of this PR. The only strange behavior I remarked with this solution is that if we open a scene tree context menu and then click in the 3d view it will not close it, but if we click in the scene tree it will close it.