Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert merge commit #6273

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Revert merge commit #6273

merged 1 commit into from
Jun 29, 2023

Conversation

BenjaminDeleze
Copy link

Command used:
git revert -m 1 7c167babc58175e5e55f17f62f4117c0dcd335ca

@BenjaminDeleze BenjaminDeleze added the bug Something isn't working label Jun 29, 2023
@BenjaminDeleze BenjaminDeleze self-assigned this Jun 29, 2023
@BenjaminDeleze BenjaminDeleze marked this pull request as ready for review June 29, 2023 07:05
@BenjaminDeleze BenjaminDeleze requested a review from a team as a code owner June 29, 2023 07:05
@BenjaminDeleze BenjaminDeleze added the test sources Start the sources test on all platforms label Jun 29, 2023
@BenjaminDeleze
Copy link
Author

Not sure if I should squash and merge or do a merge commit.

@omichel
Copy link
Member

omichel commented Jun 29, 2023

I would go for a merge commit otherwise it may mess up history (but I am not 100% sure).

@BenjaminDeleze BenjaminDeleze merged commit bb777ce into master Jun 29, 2023
41 of 42 checks passed
@BenjaminDeleze BenjaminDeleze deleted the hotfix-revert-merge branch June 29, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@BenjaminDeleze BenjaminDeleze

Labels
bug Something isn't working test sources Start the sources test on all platforms
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminDeleze @omichel