Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubNamespace should be compatible with kstatus #85

Closed
4 tasks
erikgb opened this issue Sep 25, 2023 · 2 comments · Fixed by #111
Closed
4 tasks

SubNamespace should be compatible with kstatus #85

erikgb opened this issue Sep 25, 2023 · 2 comments · Fixed by #111
Labels
enhancement New feature or request

Comments

@erikgb
Copy link
Contributor

erikgb commented Sep 25, 2023

What

We use FluxCD to provision our clusters, and FluxCD supports health checks for CRDs compatible with kstatus. And I believe ArgoCD also does this.

It would be nice if the SubNamespace CRD had a status subresource compatible with kstatus. You can read more details in the specification, but I would suggest the following requirements (at least as a start):

  • A SubNamespace with empty status has not yet been picked up by the controller
  • The controller should ensure .status.obeservedGeneration is equal to .metadata.generation when reconciling a SubNamespace
  • If the actual state differs from the desired state, the controller should add status conditions indicating that a reconcile is in progress
  • When the actual state equals the desired status, the controller should remove all status conditions
  • If the controller is unable to reconcile successfully for any reason, like in a conflict situation, the controller should add conditions indicating what's wrong.

Since the status field on SubNamespace currently is a simple string, this will be a breaking change of status.

How

Describe how to address the issue.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@zeroalphat
Copy link
Contributor

@erikgb
Thanks for your feedback.
We will investigate it.

@ymmt2005 ymmt2005 added the enhancement New feature or request label Sep 26, 2023
@ymmt2005
Copy link
Member

To address this, we need to make an incompatible change to the API.
I mean, we need to cut v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants