Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the custom rank feature for user defined resources(#640, #638, #634, #617) #655

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Revert the custom rank feature for user defined resources(#640, #638, #634, #617) #655

merged 4 commits into from
Aug 15, 2023

Conversation

terassyi
Copy link
Contributor

@terassyi terassyi commented Aug 10, 2023 •
edited
Loading

This PR reverts these pull requests listed below.
These are related with the feature for customizing the order of applying user defined resources.

@terassyi
Revert "Merge pull request #640 from cybozu-go/add-comment-for-adding…
68819de 
…-conditions-to-call-addon"

This reverts commit 40d60f8, reversing
changes made to e72fa19.
@terassyi
Revert "Merge pull request #638 from cybozu-go/fix-to-call-addon-on-P…
868ea2b 
…haseK8sMaintain"

This reverts commit e72fa19, reversing
changes made to 5ae3ee3.
@terassyi
Revert "Merge pull request #634 from cybozu-go/fix-to-apply-resources…
1bb6bd7 
…-with-same-rank"

This reverts commit a4606eb, reversing
changes made to cbe93e0.
@terassyi
Revert "Merge pull request #617 from cybozu-go/custom-rank-for-user-d…
d330ee9 
…efined-resource"

This reverts commit 9132754, reversing
changes made to d534aed.

Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
@terassyi terassyi self-assigned this Aug 10, 2023
@terassyi terassyi changed the title Revert "Merge pull request #640 from cybozu-go/add-comment-for-adding-conditions-to-call-addon" Revert the custom rank feature for user defined resources(#640, #638, #634, #617) Aug 10, 2023
@terassyi terassyi marked this pull request as ready for review August 10, 2023 08:37
@terassyi terassyi requested a review from zoetrope August 10, 2023 08:37
zoetrope
zoetrope approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terassyi terassyi merged commit e639180 into main Aug 15, 2023
6 checks passed
@terassyi terassyi deleted the revert-custom-rank-feature-for-user-defined-resources branch August 15, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoetrope zoetrope zoetrope approved these changes

Assignees

@terassyi terassyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terassyi @zoetrope