Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pods detached from Deployement are not deleted with RunnerPool deletion. #141

Open
4 tasks
kmdkuk opened this issue Mar 30, 2022 · 0 comments
Open
4 tasks

Pods detached from Deployement are not deleted with RunnerPool deletion. #141

kmdkuk opened this issue Mar 30, 2022 · 0 comments

Comments

@kmdkuk
Copy link
Contributor

kmdkuk commented Mar 30, 2022

What

Pods detached from Deployment are not deleted with RunnerPool deletion.
To reproduce.

  1. Create RunnerPool
  2. Run time-consuming jobs or extend pods used in failed jobs.
  3. Delete RunnerPool
  4. Pods used in jobs in 2. are left without being deleted.

How

When delete RunnerPool, expect to delete pods with running jobs and extending pods with it.
Example: When detaching a Pod from Deployment, set RunnerPool to the Pod's ownerReference.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmdkuk