Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ESLint v8 #522

Merged
merged 2 commits into from
Nov 16, 2021
Merged

feat: support ESLint v8 #522

merged 2 commits into from
Nov 16, 2021

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Nov 16, 2021

This is a PR to retake #501 due to the inappropriate conventional commit type. I should have used feat instead of fix 🙏

@koba04
Revert "fix(deps): update dependency eslint to v8 (#501)"
4a5dbe5 
This reverts commit db1a7d0.
@koba04
feat: support ESLint v8 (#501)
bc7ef31 
BREAKING CHANGE: this might introduce new errors that added to the recommended rules.

eslint-plugin-node hasn't supported ESLint v8 yet, so it might not work well with node presets.

This reverts commit 4a5dbe5.
@koba04 koba04 merged commit 7f2a786 into master Nov 16, 2021
@koba04 koba04 deleted the recommit-eslint-v8 branch November 16, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koba04