Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow nested run directories #3835

Closed
hjoliver opened this issue Sep 23, 2020 · 3 comments · Fixed by #3852
Closed

Disallow nested run directories #3835

hjoliver opened this issue Sep 23, 2020 · 3 comments · Fixed by #3852
Assignees
Labels
bug? Not sure if this is a bug or not
Milestone

Comments

@hjoliver
Copy link
Member

Reported by @kinow

Currently you can register and run nested flows:

$ cylc register f1 ~/suites/foo
$ cylc register f1/f2 ~/suites/foo

Cylc scan (and hence the UI) does not see the running f1/f2 flow though, because it stops recursing deeper into cylc-run/ whenever it finds a valid run directory.

Can't think of a good reason to allow this - particularly given this cylc scan problem and the potential for huge run directories.

We should prevent this at the registration stage.

@hjoliver hjoliver added the bug? Not sure if this is a bug or not label Sep 23, 2020
@hjoliver hjoliver added this to the cylc-8.0a3 milestone Sep 23, 2020
@MetRonnie MetRonnie self-assigned this Oct 2, 2020
@MetRonnie
Copy link
Member

Should we always prevent f1/f2 or only if f1 is valid run directory ( - and what is valid? If it has .service or flow.cylc/suite.rc in it?)

cc @oliver-sanders

@oliver-sanders
Copy link
Member

The .service directory is created in the registration process so would be the easiest option.

@oliver-sanders
Copy link
Member

Couple of things:

  1. In-place installations (e.g. run a suite in a temp dir)
    • Should we permit these, e.g. in the work dir (for subsuites).
  2. Might be a good time to remove the cylc register --run-dir=RUNDIR option.
    • Obsolete once we have symlink support built-in.

@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug? Not sure if this is a bug or not
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants