Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc suite database: suite events #705

Closed
arjclark opened this issue Sep 25, 2013 · 11 comments
Closed

cylc suite database: suite events #705

arjclark opened this issue Sep 25, 2013 · 11 comments
Assignees

Comments

@arjclark
Copy link
Contributor

It would be good to record suite level events in the cylc suite database such as the timeout handler being fired off, suite shutting down etc. This would be key events that may be useful for monitoring purposes rather than as a replacement for the suite log.

metomi/rose#918 relates.

@ghost ghost assigned arjclark Sep 25, 2013
@arjclark
Copy link
Contributor Author

@matthewrmshin @hjoliver - any feel for key events that would be useful to record? My initial list is:

  • started (and type)
  • shutdown
  • timeout handler run
  • shudown as result of call from remote task
  • settings broadcast to suite/tasks
  • reloading
  • restarting

@arjclark
Copy link
Contributor Author

I'm thinking something like:

Table: suite_events

Event   :  String
Details :  String
Time    :  Suite host time of event

@matthewrmshin
Copy link
Contributor

(I think we need to store the time zone of the suite host in the DB as well.)

@matthewrmshin
Copy link
Contributor

Some extra thoughts.

@matthewrmshin @hjoliver - any feel for key events that would be useful to record?

We should record any other user requests that may result in changes to the suite state.

We should include the origin of the requests.

Do we want to store any other query requests?

Some events, e.g. shut down, may require 2 or more entries or times. One entry when the suite receive the command to initiate the request, another entry when the suite carries out the request and perhaps another entry when the suite completes the request.

Not necessarily in the database, but we should keep a record of suite.rc (processed?) for each run, restart and reload.

@arjclark
Copy link
Contributor Author

I suspect it should be the processed version that gets stored.

@arjclark
Copy link
Contributor Author

Updated milestone to be done as part of the cylc refactor under #1032

@arjclark
Copy link
Contributor Author

@matthewrmshin - is this issue still relevant given all the database changes over the past year and forthcoming #1827 pull request?

@matthewrmshin
Copy link
Contributor

This is still relevant, as there is not yet a change to add a suite events table.

@benfitzpatrick benfitzpatrick modified the milestones: soon, later Jun 13, 2016
@benfitzpatrick
Copy link
Contributor

@matthewrmshin might do this as a follow on to #1827.

@matthewrmshin
Copy link
Contributor

settings broadcast to suite/tasks

Done #1827.

We should record any other user requests that may result in changes to the suite state.
We should include the origin of the requests.
Do we want to store any other query requests?

These are in the suite log since #1480.

Not necessarily in the database, but we should keep a record of suite.rc (processed?) for each run, restart and reload.

Done #1272 as files under log/suiterc/.

@matthewrmshin
Copy link
Contributor

Closing as superseded, as I have consolidated the items of this issue to #1032, and or commented on them above.

@matthewrmshin matthewrmshin removed this from the soon milestone Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants