Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if root dir set #37

Closed
wxtim opened this issue Feb 23, 2021 · 1 comment · Fixed by #39
Closed

Warn if root dir set #37

wxtim opened this issue Feb 23, 2021 · 1 comment · Fixed by #39
Assignees
@wxtim
Labels
good first issue Good for newcomers question Flag this as a question for the next Cylc project meeting.
Milestone
0.1.0

Comments

@wxtim
Copy link
Member

wxtim commented Feb 23, 2021

The root dir setting of rose-suite.conf was made obsolete by cylc-flow PR #3688.

If it is set cylc-rose should log a warning and do nothing.

@oliver-sanders in cylc/cylc-flow#3819, does "do nothing" mean "fail with an error", or "ignore value with warning"?

Pull requests welcome!
@wxtim wxtim added good first issue Good for newcomers question Flag this as a question for the next Cylc project meeting. labels Feb 23, 2021
@wxtim wxtim self-assigned this Feb 23, 2021
@wxtim wxtim mentioned this issue Feb 23, 2021
Closed
11 tasks
@oliver-sanders
Copy link
Member

I think "ignore with warning".

@wxtim wxtim added this to the 1.0.0 milestone Feb 24, 2021
@wxtim wxtim mentioned this issue Feb 24, 2021
Merged
@wxtim wxtim closed this as completed in #39 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wxtim wxtim

Labels
good first issue Good for newcomers question Flag this as a question for the next Cylc project meeting.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Root dir warning wxtim/cylc-rose
2 participants
@oliver-sanders @wxtim