Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtriggers (graph view) #131

Open
2 tasks done
oliver-sanders opened this issue Jul 16, 2019 · 4 comments
Open
2 tasks done

xtriggers (graph view) #131

oliver-sanders opened this issue Jul 16, 2019 · 4 comments
Labels
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jul 16, 2019

Add Xtriggers into the Graph View.

The Cylc7 Graph View has basic support for Xtriggers, the Cylc8 Graph View has a lot more potential.

We should provide special representations for Cylc Flow built-in xtriggers and some default representation for user defined Xtriggers.

xtriggers

Open questions:

  • Should Xtriggers disappear once satisfied? - No
    • Retry Xtriggers should, custom Xtriggers maybe not - Retry should remain visible
    • If not we could allow them to be reset from the GUI, see Allow xtriggers to be reset cylc-flow#3221
    • If not we need a way to show whether an Xtrigger has been satisfied or not - Yes, use a tick or success icon of some form
  • Should queues use option (1) or (2) or something else? - Something else, use a badge in the same location as the held icon
@kinow kinow added this to the 0.2 milestone Sep 14, 2019
@kinow kinow changed the title xtriggers xtriggers (graph view) Oct 15, 2019
@oliver-sanders oliver-sanders added the question Flag this as a question for the next Cylc project meeting. label Dec 15, 2019
@oliver-sanders oliver-sanders modified the milestones: 0.2, 1.0 Dec 15, 2019
@hjoliver
Copy link
Member

Should queues use option (1) or (2) or something else?

Shouldn't be too messy if queue "triggers" are only shown when the task is actively held back - i.e. ready to submit as soon as released by the queue.

@oliver-sanders
Copy link
Member Author

True, perhaps we should add logic to Cylc Flow for this special case.

However it is common to see suites (e.g. rose stem) where almost all tasks would be held back by a queue.

@oliver-sanders
Copy link
Member Author

@hjoliver one for the workshop.

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Feb 10, 2020

[cylc-con-2020]

  • We are happy with this
  • However, queues are special, they should appear next to the task icon in the space where the held modifier is located. The held badge should take priority, the queue secondarily.
  • Xtriggers should remain after they succeed but their icon should be replaced with a tick or succeeded icon.

@oliver-sanders oliver-sanders removed the question Flag this as a question for the next Cylc project meeting. label Mar 16, 2020
@kinow kinow modified the milestones: 1.0, 2.0 Sep 10, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants