Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GScan #139

Closed
6 of 8 tasks
oliver-sanders opened this issue Jul 19, 2019 · 7 comments
Closed
6 of 8 tasks

GScan #139

oliver-sanders opened this issue Jul 19, 2019 · 7 comments
Assignees

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jul 19, 2019

Implement the GScan (workflows) view.

  • Should share the tree collapse/expand features of the tree and dot views
    (we decided not to share the gscan and workflow tree components - not similar enough)
  • Display workflow registration hierarchy
  • Search workflows by name - moved to GScan: search and filter #337
  • Filter workflows by discrete data (done for task/job states, but not e.g. cylc version or workflow host, see mockup in GScan: search and filter #337) - moved to gscan: metadata filtering #581
  • Show running workflow status (running, held)
  • Show stopped (not running) workflows
  • Show number of jobs in each state and "most recent" summary
  • Show warning triangle when errors occur (requires UIS log file scanning data stream) moved to warning icons ⚠️ #632

Should close #54

@oliver-sanders oliver-sanders self-assigned this Jul 19, 2019
@oliver-sanders oliver-sanders mentioned this issue Jul 19, 2019
14 tasks
@kinow kinow added this to the 0.2 milestone Sep 14, 2019
@kinow
Copy link
Member

kinow commented Oct 30, 2019

Spent some time this morning playing with the tree component. Unfortunately it won't be easy to customize it to support the requirements for the GScan from the design sketch. Not without adding slots.

I tried to use a maxDepth, which would be set at 0, i.e. only display the first level with cycle points. But there are still some CSS changes like the height of the elements, and the position.

Only option for now is copying. But I thought it would be better to wait for the PR of family and subscription first, then spend at least half day porting the code to render function and jsx.

If in half day I manage to convert over 50% of the code, then I think it should be possible to add the slots. The issue is that the current code isn't ready for production, and copying it could lead to more issues. So at least having a single component, fixing performance issues can be done in a single place.

@hjoliver
Copy link
Member

Note the old gscan allows you to expand each suite down to cycle-point level but not lower (i.e. a summary of what's happening per cycle point, but not individual families or tasks). I would say that is a useful feature but not critical. The sketch above doesn't show this, but I can't recall if we discussed it in relation to Cylc 8 (do you, @oliver-sanders ?)

@oliver-sanders
Copy link
Member Author

Purposely omitted! The main function was to give a bit more info in GScan (to avoid having to open the GUI) but in the new design we already have the GUI open so I think it would be a bit superfluous.

@kinow
Copy link
Member

kinow commented Jan 6, 2020

Should we move this to 0.3 or later?

@oliver-sanders oliver-sanders modified the milestones: 0.2, 0.3 Jan 6, 2020
@oliver-sanders
Copy link
Member Author

Bumped to 0.3 for now, we've part addressed it at 0.2 anyway.

@kinow
Copy link
Member

kinow commented Sep 22, 2020

Updated the check list, checking the item with stopped workflows

@oliver-sanders oliver-sanders modified the milestones: 0.3, 0.4 Mar 25, 2021
@oliver-sanders oliver-sanders modified the milestones: 0.4.0, 0.5.0 Apr 16, 2021
@kinow kinow mentioned this issue Jul 21, 2021
6 tasks
@oliver-sanders oliver-sanders modified the milestones: 0.5.0, 0.6.0 Jul 28, 2021
@kinow kinow modified the milestones: 0.6.0, 2.0 Sep 10, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
@oliver-sanders oliver-sanders removed this from the Pending milestone Oct 27, 2022
@oliver-sanders
Copy link
Member Author

Closing this umbrella ☂ issue and moving the two related points to other issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants