Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplicated code when using WorkflowService #160

Closed
kinow opened this issue Aug 1, 2019 · 0 comments · Fixed by #543
Closed

Reduce duplicated code when using WorkflowService #160

kinow opened this issue Aug 1, 2019 · 0 comments · Fixed by #543
Assignees
@kinow
Milestone
0.5.0

Comments

@kinow
Copy link
Member

kinow commented Aug 1, 2019

Just added the WorkflowService to Dashboard.vue in #149 , and noticed that ended up with some code duplicated that seems boilerplate for polling data. Some of the code may go away with WebSockets, but I suspect some of that would remain.

e.g. the methods are pretty much the same, and could be in a Object or a Mixin?
@kinow kinow added this to the 1.0 milestone Sep 14, 2019
@kinow kinow mentioned this issue Jun 23, 2021
Merged
9 tasks
@kinow kinow self-assigned this Jul 5, 2021
@kinow kinow modified the milestones: 1.0, 0.5.0 Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinow kinow

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Use deltas in GScan kinow/cylc-ui
1 participant
@kinow