-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if we can use states and stateTotals in the GScan instead of jobs #401
Comments
Cylc 7The task states are retrieved in the GScan application every 1 second, when the GScan The HTTP server simply returns the existing values, that are created when the |
Do you mean we're missing |
So we will need to add that (or something similar) in to the new code. |
I was just looking at how it was done in Cylc 7. Next up is understand how it's being implemented in |
Cylc 8 (cylc monitor)From what I understood, Cylc 8's |
Thanks David! Tomorrow I was going to look at our schema, and ask you whether we were going to have the same or, if later that But looks like we will get the new fields in the schema. Updating GScan (vue) should be really straightforward after that. Thanks! |
Just working on the grouped deltas (as shown above), and then will continue converting the CLI. |
I think you mean #499? - so that can close this issue? |
Ops, wrong issue linked. Thanks. Not sure if this can be closed. I think there's still the workflow summaries. I'm iterating the list of task proxies. We had a discussion some days ago about adding some of that info to GraphQL queries. Not sure if that should go under states or stateTotals though (if not we can then close this one I think) |
Ah, right. Yeah we don't want gscan to be requesting all the task proxies. |
State totals tool-tips "most recent tasks by state" blocked by: cylc/cylc-flow#3976 |
Are we sure we can't just use something like this:
? And then add a limit argument to return only 5? Or do we just want to create a static list of |
Will that give us the most recent tasks, for each state? E.g. we want the most recent 5 task failures, not just 5 failed tasks ordered alphanumerically by name or whatever. |
You can sort by cycle-point/submit and filter by state ... Then apply the limit last (which might be inefficient.. as limiting first would mean the resolvers don't have to return all) |
We may need a "update_time" field added to all nodes (so we can sort by that)... Beauty of deltas is; it's ok for there to be heaps of fields (as not all are sent on each update).. However, this one will be sent with any update (doesn't have to be "any" I suppose).. The alternate approach might put less strain on the back end; just create a static dump of tasks (in string for) for each state when needed on all state changes.. Although, this would be a constant thing for the workflows (whether someone is watching or not).. In either case the backend would need to;
But it doesn't seam that scalable if you have thousands of tasks to filter and sort through on ever state update... Perhaps we can do it smarter on the backend... i.e.
This would be scalable |
Describe exactly what you would like to see in an upcoming release
ATM, the
GScan
component uses theworkflow.jobs
in the GraphQL query. During the Cylc Meetup 2020, it was pointed we could instead useworkflow.states
andworkflow.stateTotals
.It appears to be missing the task name, so we may need to review how Cylc 7 was doing it.
Additional context
Pull requests welcome!
The text was updated successfully, but these errors were encountered: