Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree component filtering #482

Closed
4 tasks
kinow opened this issue Aug 20, 2020 · 3 comments · Fixed by #483
Closed
4 tasks

Tree component filtering #482

kinow opened this issue Aug 20, 2020 · 3 comments · Fixed by #483

Comments

@kinow
Copy link
Member

kinow commented Aug 20, 2020

Describe exactly what you would like to see in an upcoming release

Allow users to apply filters to the Tree component.

Additional context

Similar to Cylc 7's GUI feature:

image

Pull requests welcome!

@kinow
Copy link
Member Author

kinow commented Aug 21, 2020

Note: Cylc 7 GUI filter returned only the branch of the tree with the tasks found.

image

The example above was a quick test, filtering in the TreeItem (recursive component) for "sleepy". Telling it to not render tasks that do not match a filter - if provided. And also not rendering the children (jobs) nodes.

While the simplest way to implement it, we end up with child-less nodes in the tree.

Back to the drawing board.

@oliver-sanders
Copy link
Member

  • Filtering per-view.
  • The default filters should work in all views.
  • Accessible via the view toolbar.

I think it would be a good idea to keep the filters simple for now (i.e. job state and possibly task name) and to add other filters slowly when we are able to find efficient ways of implementing them.

@hjoliver
Copy link
Member

(i.e. job state and possibly task name

Task name is a must have IMO. Some enormous suites have long complex hard-to-parse-at-glance task names, and filtering by state isn’t going to help much if you’re not looking for an active or failed task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants