Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the current graph view and component #515

Closed
9 tasks done
kinow opened this issue Oct 7, 2020 · 0 comments · Fixed by #517
Closed
9 tasks done

Remove the current graph view and component #515

kinow opened this issue Oct 7, 2020 · 0 comments · Fixed by #517
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@kinow
Copy link
Member

kinow commented Oct 7, 2020

Describe exactly what you would like to see in an upcoming release

It was decided in our last meeting that the current Graph view and component are not working as expected for Cylc 8. Since we are still going to look at options for displaying the graph in the UI, we can safely remove the current version.

That will save us time having to update GraphQL queries, test the Graph view/component when other things are changed, and maintain the dependencies that come with the view/component (e.g. cytoscape & transitive deps like jquery).

You'd need to build & test the app several times, doing something like (not necessarily in this order)

  • remove Graph View
  • remove Graph Component
  • remove any state in Vuex that was used for the Graph
  • remove any mixin used for the Graph
  • remove any util code used for the Graph
  • remove Vue Router routes for the Graph View
  • remove the GraphQL queries from the Graph (or leave them commented out, or just leave without use, but check the linter)
  • remove unit & e2e tests
  • remove dependencies from package.json

Additional context

The placeholder for the graph view is #74. Follow the linked issues, or search for "graph" on GitHub UI for more issues related to graph view & components — if interested.

See readme and package.json for build commands.

Pull requests welcome!

@kinow kinow added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 7, 2020
@kinow kinow added this to the 0.3 milestone Oct 7, 2020
@kinow kinow changed the title Remove the current graph view Remove the current graph view and component Oct 7, 2020
@datamel datamel self-assigned this Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants