Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example spec file too long #9

Closed
bencao opened this issue Mar 30, 2017 · 7 comments · Fixed by #62
Closed

example spec file too long #9

bencao opened this issue Mar 30, 2017 · 7 comments · Fixed by #62
Assignees

Comments

@bencao
Copy link

bencao commented Mar 30, 2017

The example_spec.js file is too long.
Could we cut it into separate files, each demonstrate a specific functionality like request_spec.js etc?

@brian-mann
Copy link
Member

Agreed it is too long - but this is the file that is "seeded" when new projects are created.

We could either combine them back into one file just for the seeding, or seed multiple files (which may be annoying).

I think another option is during the seeding phase to give users a button that's like "I know what I'm doing, please remove these files..."

@bencao
Copy link
Author

bencao commented Mar 30, 2017

how about using an examples/ directory to hold them all?

@bahmutov
Copy link
Contributor

Yeah, I am all for splitting this long spec file into many files showing different types of tests. And our scaffolding could generate multiple files as well

@brian-mann
Copy link
Member

Definitely +1. We've talked internally about changing the entire scaffolding process.

Not only is it too long but running 90 tests in GUI mode is not the intended use case and has many problems on its own.

Splitting it up more accurately reflects how you should be using GUI mode, will be less intimidating, and help organize the various commands into their separate concerns.

@bahmutov
Copy link
Contributor

Adding better cypress init command here cypress-io/cypress#619

@brian-mann
Copy link
Member

The GUI also needs to be updated to prompt the user, but allow them to decline scaffolding the example files.

Only power users using Cypress on a bunch of projects will use the cypress init command line. Whereas the vast majority of our users will go through the GUI.

@jennifer-shehane
Copy link
Member

Related to: cypress-io/cypress#681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants