Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

skipOn should respect environment name #41

Open
bahmutov opened this issue Feb 9, 2020 · 6 comments
Open

skipOn should respect environment name #41

bahmutov opened this issue Feb 9, 2020 · 6 comments

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Feb 9, 2020

Not just isOn

// CYPRESS_ENVIRONMENT=draft
skipOn('draft', () => { ... })
@rafael-anachoreta
Copy link
Contributor

Hey @bahmutov , are you accepting PRs for this issue? I've stumbled upon it and would love to have it fixed.

@bahmutov
Copy link
Contributor Author

bahmutov commented Mar 11, 2020 via email

@Darex1991
Copy link

hey @bahmutov any news? I would love to have this :)

@rafael-anachoreta
Copy link
Contributor

That's my bad, I was meant to have submitted the PR. I'll get to it later today.

@rafael-anachoreta
Copy link
Contributor

@bahmutov I've created the PR above to address this issue. Let me know your thoughts!

@unikitty37
Copy link

Is there any more news on this?

I can skip using cy.skipOn(Cypress.env('ENVIRONMENT') === 'whatever'), but it leaves a rather cryptic log message of skipOn false rather than skipOn whatever, so it's not ideal for readability…

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants