This repository has been archived by the owner on Oct 13, 2022. It is now read-only.
feat: Add type definitions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasBoll
commented
Dec 16, 2018
| * cy.xpath(`//ul[@class="todo-list"]//li`) | ||
| * .should('have.length', 3) | ||
| */ | ||
| xpath<E extends Node = HTMLElement>(selector: string, options?: Partial<Loggable & Timeoutable>): Chainable<JQuery<E>> |
There was a problem hiding this comment.
The command doesn't actually allow configuration of log, but should allow timeout config. Either the type definition should not include Loggable or the implementation should allow disabling logging.
|
@NicholasBoll first - thank you! second - I have just added CLA assistant to this repo, could you sign the CLA and then I will be happy to merge the type definition for this command (and will make a separate issue about logging option) |
|
@bahmutov Signed! |
Closed
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4