Skip to content

Commit

Permalink
fix: Resolve types and dist issues with @cypress/puppeteer (#28424)
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisbreiding authored Nov 29, 2023
1 parent eb9fa1b commit 72225db
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion npm/puppeteer/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

### Features

* Add @cypress/puppeteer plugin ([#28370](https://github.com/cypress-io/cypress/issues/28370)) ([b34d145](https://github.com/cypress-io/cypress/commit/b34d14571689a9b36efc707a3a48f27edcb98113))
* Initial release ([#28370](https://github.com/cypress-io/cypress/issues/28370)) ([b34d145](https://github.com/cypress-io/cypress/commit/b34d14571689a9b36efc707a3a48f27edcb98113))
6 changes: 3 additions & 3 deletions npm/puppeteer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Add the following in `tsconfig.json`:
```json
{
"compilerOptions": {
"types": ["cypress", "@cypress/puppeteer"]
"types": ["cypress", "@cypress/puppeteer/support"]
}
}
```
Expand All @@ -55,7 +55,7 @@ While the `cy.puppeteer()` command is executed in the browser, the majority of t
In your Cypress config (e.g. `cypress.config.ts`):

```typescript
import { setup } from '@cypress/puppeteer/plugin'
import { setup } from '@cypress/puppeteer'

export default defineConfig({
e2e: {
Expand All @@ -76,7 +76,7 @@ export default defineConfig({
In your support file (e.g. `cypress/support/e2e.ts`):
```typescript
import { setup } from '@cypress/puppeteer/support'
import '@cypress/puppeteer/support'
```
In your spec (e.g. `spec.cy.ts`):
Expand Down
4 changes: 2 additions & 2 deletions npm/puppeteer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
},
"files": [
"dist",
"index.d.ts"
"support"
],
"types": "index.d.ts",
"types": "dist/plugin/index.d.ts",
"license": "MIT",
"repository": {
"type": "git",
Expand Down
File renamed without changes.
1 change: 1 addition & 0 deletions npm/puppeteer/support/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
require('../dist/support')
4 changes: 2 additions & 2 deletions npm/puppeteer/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
"strictNullChecks": true,
"target": "ES2020",
"types": [
"cypress"
"cypress",
"./support"
]
},
"include": [
"index.d.ts",
"src/"
]
}

5 comments on commit 72225db

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 72225db Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.6.1/linux-arm64/develop-72225db03327744844dcfbcc72b40e85de6a2761/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 72225db Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.6.1/linux-x64/develop-72225db03327744844dcfbcc72b40e85de6a2761/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 72225db Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.6.1/darwin-x64/develop-72225db03327744844dcfbcc72b40e85de6a2761/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 72225db Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.6.1/darwin-arm64/develop-72225db03327744844dcfbcc72b40e85de6a2761/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 72225db Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.6.1/win32-x64/develop-72225db03327744844dcfbcc72b40e85de6a2761/cypress.tgz

Please sign in to comment.