Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying cypress binary location from .npmrc #1399

Closed
jedateach opened this issue Mar 1, 2018 · 2 comments · Fixed by #1855
Closed

Allow specifying cypress binary location from .npmrc #1399

jedateach opened this issue Mar 1, 2018 · 2 comments · Fixed by #1855
Assignees
@kuceb
Labels
type: feature New feature that does not currently exist
Milestone
3.0.2

Comments

@jedateach
Copy link

jedateach commented Mar 1, 2018 •
edited by jennifer-shehane
Loading

Current behavior:

https://docs.cypress.io/guides/getting-started/installing-cypress.html#Environment-Variables

Desired behavior:

Rather than needing to introduce an environment variable outside of npm land, it would be nice to specify a cypress_binary_version npm config inside the .npmrc file.

This means our devs only need to type npm install, and don't need to think about specifying environment variables.

This is how PhantomJS does it.
https://github.com/Medium/phantomjs#deciding-where-to-get-phantomjs

How to reproduce:

npm install

  • Operating System: Linux
  • Cypress Version: 1.4.2
  • Browser Version: Chrome 60
@bahmutov
Copy link
Contributor

bahmutov commented Mar 2, 2018

Hmm, that is not a bad idea!

@jennifer-shehane jennifer-shehane added type: feature New feature that does not currently exist stage: proposal 💡 No work has been done of this issue labels Mar 6, 2018
@kuceb kuceb self-assigned this Jun 1, 2018
@kuceb kuceb mentioned this issue Jun 1, 2018
Closed
@kuceb kuceb added this to the 3.0.2 milestone Jun 1, 2018
@brian-mann brian-mann mentioned this issue Jun 1, 2018
Merged
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: in progress stage: needs investigating Someone from Cypress needs to look at this stage: proposal 💡 No work has been done of this issue stage: needs review The PR code is done & tested, needs review stage: ready for work The issue is reproducible and in scope labels Jun 27, 2018
@brian-mann
Copy link
Member

Released in 3.0.2.

This was referenced Jan 28, 2019
Closed
Closed
@schanne schanne mentioned this issue Nov 30, 2023
Open
@ajesse11x ajesse11x mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuceb kuceb

Labels
type: feature New feature that does not currently exist
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

env vars from configs, respect loglevel from npm cypress-io/cypress
5 participants
@brian-mann @jennifer-shehane @jedateach @bahmutov @kuceb