feat: Remove experimentalRunEvents flag

[chrisbreiding]

• Addresses TR-671

User facing changelog

• The experimentalRunEvents configuration flag has been removed. It is no longer necessary to enable listening to run events in the plugins file.

PR Tasks

• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation? Remove experimentalRunEvents flag cypress-documentation#3621
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[bahmutov]

Will these events be enabled in both interactive and non-interactive modes?

[chrisbreiding]

Just run mode for the time being.

[bahmutov]

I was hoping both, so I could switch code coverage plugin to it, otherwise no luck, has to happen in both modes https://github.com/cypress-io/code-coverage

[chrisbreiding]

That requires more discussion and work to implement. For now, we're just removing the flag.

[cypress]

---

Test summary

9362 • 2 • 118 • 3 • 1

---

Run details

Project	cypress
Status	Failed
Commit	6a81fd1
Started	Mar 2, 2021 3:17 PM
Ended	Mar 2, 2021 3:29 PM
Duration	11:22 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Failures

	cypress/integration/commands/querying_spec.js		2
1	... > retries until length equals n
2	... > route aliases > returns the 2nd xhr when dots in alias

---

Flakiness

	cypress/integration/retries.ui.spec.js		1
1	runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

would it be good to add this to breakingOptions at the bottom of this file, so users get a warning that it's no longer required to pass this option?

[jennifer-shehane]

I'm trying to see that the events work without the flag and I can't console.log any of the details. I know I have the changes because I see the new warning message. Am I missing something? Running via yarn start.

module.exports = (on, config) => {
  on('before:run', (details) => { 
    console.log(details) 
  })
  on('before:spec', (spec) => { 
    console.log(spec) 
  })
  on('after:spec', (spec, results) => { 
    console.log(spec, results) 
  })
  on('after:run', (results) => { 
    console.log(results) 
  })
}

Also, when did this happen to our CSS? 😳 This error message on the plugins is completely weird.

[chrisbreiding]

I'm trying to see that the events work without the flag and I can't console.log any of the details. I know I have the changes because I see the new warning message. Am I missing something? Running via yarn start.

These events only fire in run mode, so you won't see them with yarn start.

As for the CSS, I think the bootstrap upgrade would be the most likely culprit.

[jennifer-shehane]

@chrisbreiding We didn't upgrade bootstrap recently that I'm aware of. Do you have a PR link?

I'll open a new PR to fix the CSS issue.

[chrisbreiding]

My mistake, I thought we had merged the bootstrap upgrade, but we haven't. Maybe the node-sass change?

[cypress-bot]

Released in 6.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.7.0, please open a new issue.