Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multidomain: Better coordinate timing when secondary domain is visited #16778

Closed
chrisbreiding opened this issue Jun 2, 2021 · 1 comment
Closed

Multidomain: Better coordinate timing when secondary domain is visited #16778

chrisbreiding opened this issue Jun 2, 2021 · 1 comment
Assignees
@chrisbreiding

Comments

@chrisbreiding
Copy link
Contributor

chrisbreiding commented Jun 2, 2021 •
edited
Loading

Currently, switching to a secondary domain communicates with the driver asynchronously initially, but it needs to be synchronous, with window.Cypress available before the page loads. This will enable overriding DOM properties and methods.
@chrisbreiding chrisbreiding self-assigned this Jun 2, 2021
@chrisbreiding chrisbreiding changed the title Multidomain: Better coordinate timing when secondary domain is visited Multidomain: Better coordinate timing when secondary domain is visited and enable window:before:load Jul 8, 2021
@chrisbreiding chrisbreiding changed the title Multidomain: Better coordinate timing when secondary domain is visited and enable window:before:load Multidomain: Better coordinate timing when secondary domain is visited Jul 9, 2021
@chrisbreiding chrisbreiding mentioned this issue Jul 9, 2021
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jul 9, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 12, 2021

The code for this is done in cypress-io/cypress#17262, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 12, 2021
@jennifer-shehane jennifer-shehane mentioned this issue Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbreiding chrisbreiding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisbreiding