Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow image markdown in assertions and Command Log #17357

Closed
bahmutov opened this issue Jul 15, 2021 · 2 comments · Fixed by #17777
Closed

Do not allow image markdown in assertions and Command Log #17357

bahmutov opened this issue Jul 15, 2021 · 2 comments · Fixed by #17777
Assignees
@sainthkh
Labels
pkg/reporter This is due to an issue in the packages/reporter directory

Comments

@bahmutov
Copy link
Contributor

Current behavior

I was testing a little utility function when suddenly

const changed = updateRelativeUrls(baseUrl, md)
expect(changed).to.equal('![JSDoc example](/slides/img/jsdoc.png)')

Screen Shot 2021-07-15 at 17 05 50

Desired behavior

The image markup should do nothing in the command log

Test code to reproduce

const text = '![JSDoc example](/slides/img/jsdoc.png)'
expect(text).to.equal(text)

Cypress Version

7.7.0

Other

No response
@sainthkh sainthkh added stage: ready for work The issue is reproducible and in scope pkg/reporter This is due to an issue in the packages/reporter directory labels Aug 11, 2021
@sainthkh sainthkh mentioned this issue Aug 18, 2021
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Aug 18, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 19, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 19, 2021

The code for this is done in cypress-io/cypress#17777, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 27, 2021

Released in 8.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sainthkh sainthkh

Labels
pkg/reporter This is due to an issue in the packages/reporter directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not allow image markdown in assertions and command log sainthkh/cypress
2 participants
@bahmutov @sainthkh