Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release command log items in run mode #25230

Closed
mschile opened this issue Dec 20, 2022 · 5 comments · Fixed by #25632
Closed

Release command log items in run mode #25230

mschile opened this issue Dec 20, 2022 · 5 comments · Fixed by #25632
Assignees
Labels

Comments

@mschile
Copy link
Contributor

mschile commented Dec 20, 2022

What would you like?

In headless run mode, the command log cannot be interacted with, as such, the logs in the command log do not need to be retained and can be released. See this comment for additional details.

Why is this needed?

Don't unnecessarily consume memory.

Other

No response

@hegeds
Copy link

hegeds commented Jan 23, 2023

Hey,
just curious what are the plans for this? I'm just wondering, because from my perspective it would be great, if the number of retained commands would be user configurable 🤔

@mschile
Copy link
Contributor Author

mschile commented Jan 30, 2023

Hi @hegeds 👋, my plan is to remove the logs from the reporter for any successful tests in run mode. In this context, I'm not sure there will be a lot of benefit to have the number of retained commands to be user configurable. That may be something to consider for open mode though.

@hegeds
Copy link

hegeds commented Jan 31, 2023

oh I see, this can be a major improvement in suites where there are multiple quick test cases! However we also have quite a few longer test cases, where we have OOM crashes. This is why I would be interested in a solution, where one could set that only the last x number of logs are kept even in headless mode

@mschile
Copy link
Contributor Author

mschile commented Jan 31, 2023

Thanks for the clarification @hegeds. We are hopefully releasing this change today. If you are still receiving OOM crashes after updating, could you please log a new memory issue. We have discussed single tests that consume large amounts of memory but we would like some more metrics before we make any changes.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 31, 2023

Released in 12.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants