Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IATR](M1.0) - Update artifact links on Debug page to only show when urls available #25319

Closed
warrensplayer opened this issue Dec 30, 2022 · 1 comment
Assignees

Comments

@warrensplayer
Copy link
Contributor

Current Behavior
Artifact Links shown in DebugFailedTest and GroupedDebugFailedTest are always present, even if the test does not have URLs for the different artifacts present.

Example from DebugFailedTest.vue

debugArtifacts: [
      { icon: 'TERMINAL_LOG', text: 'View Log', url: runInstance?.stdoutUrl! },
      { icon: 'IMAGE_SCREENSHOT', text: 'View Screenshot', url: runInstance?.screenshotsUrl! },
      { icon: 'PLAY', text: 'View Video', url: runInstance?.videoUrl! },
    ],

Desired Behavior
Code should check to see if the various artifacts are present by checking the three boolean fields that map to each artifact type and only rendering the buttons if they are true. The fields are hasStdout, hasVideo and hasScreenshots

@warrensplayer
Copy link
Contributor Author

@ZachJW34 ZachJW34 self-assigned this Jan 4, 2023
@warrensplayer warrensplayer changed the title [IATR](M1.1) - Update artifact links on Debug page to only show when urls available [IATR](M1.0) - Update artifact links on Debug page to only show when urls available Jan 4, 2023
@ZachJW34 ZachJW34 closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants