Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate resourceType in cy.intercept #30433

Closed
mschile opened this issue Oct 21, 2024 · 2 comments · Fixed by #30512
Closed

Deprecate resourceType in cy.intercept #30433

mschile opened this issue Oct 21, 2024 · 2 comments · Fixed by #30512
Assignees
@jennifer-shehane
Labels
Cypress 14 Issues scoped for Cypress 14

Comments

@mschile
Copy link
Contributor

mschile commented Oct 21, 2024

What would you like?

We would like to deprecate resourceType within cy.intercept. The resourceType comes from CDP today in the pre-request. In order to potentially remove proxy correlation, we need to remove the dependency on resourceType. In addition, since the values come from CDP, with the transition to BiDi, these values may no longer be the same.

Why is this needed?

No response

Other

No response
@mschile mschile added the Cypress 14 Issues scoped for Cypress 14 label Oct 21, 2024
@AtofStryker
Copy link
Contributor

If we remove cy.intercept(), we also need another way to disable proxy logging since log: false can no longer be used once the field changes or is removed

@AtofStryker AtofStryker mentioned this issue Oct 23, 2024
Closed
@jennifer-shehane jennifer-shehane moved this from Understanding to Designing / Scoping in Cypress App Priorities Oct 25, 2024
@jennifer-shehane jennifer-shehane mentioned this issue Nov 1, 2024
Merged
3 tasks
@jennifer-shehane jennifer-shehane self-assigned this Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Building to Generally Available in Cypress App Priorities Nov 5, 2024
@jennifer-shehane jennifer-shehane moved this from Generally Available to Building in Cypress App Priorities Dec 12, 2024
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 16, 2025

Released in 14.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 16, 2025
@jennifer-shehane jennifer-shehane moved this from Building to Generally Available in Cypress App Priorities Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jennifer-shehane jennifer-shehane

Labels
Cypress 14 Issues scoped for Cypress 14
Projects
Cypress App Priorities
Status: Generally Available
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecation: Deprecate resource type of intercept's request object cypress-io/cypress
3 participants
@jennifer-shehane @mschile @AtofStryker