Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @packages/reporter and @packages/app to use mobx v6 and mobx-react v9 #30509

Closed
AtofStryker opened this issue Nov 1, 2024 · 2 comments · Fixed by #30514
Closed

Update @packages/reporter and @packages/app to use mobx v6 and mobx-react v9 #30509

AtofStryker opened this issue Nov 1, 2024 · 2 comments · Fixed by #30514
Assignees
@AtofStryker
Labels
Cypress 14 Issues scoped for Cypress 14 pkg/reporter This is due to an issue in the packages/reporter directory

Comments

@AtofStryker
Copy link
Contributor

What would you like?

Currently, the Cypress reporter uses an old version of mobx and mobx-react that works with React 16-18.2.

Why is this needed?

If Cypress wants to update to LTS react 18.3.1, we will need to update mobx-react from v5 to v9 and mobx from v5 to v6

Other

see the mobx migration guide. Leveraging the mobx-undecorate package is also extremely helpful when migration (for our use case, npx mobx-undecorate --keepDecorators
@AtofStryker AtofStryker added the pkg/reporter This is due to an issue in the packages/reporter directory label Nov 1, 2024
@AtofStryker AtofStryker self-assigned this Nov 1, 2024
@AtofStryker
Copy link
Contributor Author

AtofStryker commented Nov 1, 2024 •
edited
Loading

WIP branch chore/update_reporter_mobx https://app.circleci.com/pipelines/github/cypress-io/cypress/65167

@jennifer-shehane jennifer-shehane added the Cypress 14 Issues scoped for Cypress 14 label Nov 1, 2024
@AtofStryker AtofStryker mentioned this issue Nov 1, 2024
Merged
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2024

Released in 13.15.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AtofStryker AtofStryker

Labels
Cypress 14 Issues scoped for Cypress 14 pkg/reporter This is due to an issue in the packages/reporter directory
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @AtofStryker