If video failed uploading, do not send video.url

[jennifer-shehane]

@jennifer-shehane commented on Thu Jun 14 2018

Within run:

  (Uploading Results)

  - Failed Uploading (1/1) /root/app/cypress/videos/common/select-spec.js.mp4

Yet, the video url is sent with an aws link still.

https://dashboard.cypress.io/#/projects/m7bnkc/runs/4/specs

---

@brian-mann commented on Thu Jun 14 2018

The API doesn't actually know whether or not the uploading failed. It just assumes it was all successful.

For us to capture this state we would either need to send it along from the desktop client - or we'd need a lambda function to spawn in response to files being uploaded to buckets - which would then update the DB state.

Although it would be initially easier to do this out of the clients, its unnecessary and much less flexible (it wouldnt work on older versions) and I think we'd rather opt to go the lambda route because we will have to do that anyway when we do things like log processing.

[hari49951]

Hi @jennifer-shehane, I am running my tests on GitHub actions and tests are running fine but the video is not uploading to dashboard. I see this in the output "

(Uploading Results)
Failed Uploading (1/1) C:\actions-runner_work\omv-cypress-neal\omv-cypress-neal\cypress\videos\cucumber-tests\Offices\OfficeList\OfficeList.feature.mp4".

Is this issue resolved? Thanks!

[mshivasaketh]

Surfacing the same issue in our setup. After the spec, failed testcases videos are uploading. At the end got this failure.

• Failed Uploading (11/11) /cypress/videos/encryption/encryption_mssql.spec.js.mp4
  As soon as this occurs the whole suite is timed out.

[Jeffintel]

I also had the exact same issue with the screenshot in Cypress Dashboard. is the fix coming soon?

  - Failed Uploading (1/1) /var/jenkins_home/cypress-artifacts/imageName(failed).png

[robrich7]

I also had the same issue with a video upload. if it fails then the whole suite is timed out. thats really bad!

[cypress-app-bot]

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

[cypress-app-bot]

This issue has been closed due to inactivity.