Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More layout issues in Desktop GUI #4912

Closed
chrisbreiding opened this issue Aug 2, 2019 · 4 comments · Fixed by #4914
Closed

More layout issues in Desktop GUI #4912

chrisbreiding opened this issue Aug 2, 2019 · 4 comments · Fixed by #4914
Assignees
@chrisbreiding
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory

Comments

@chrisbreiding
Copy link
Contributor

chrisbreiding commented Aug 2, 2019 •
edited
Loading

Warning banner does not layout properly (though I kind of like it this way 😄)
Screen Shot 2019-08-02 at 9 07 19 AM

Footer not at bottom when there's a full-page error message:

Screen Shot 2019-08-02 at 9 26 56 AM
@chrisbreiding chrisbreiding added the pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory label Aug 2, 2019
@chrisbreiding chrisbreiding self-assigned this Aug 2, 2019
@chrisbreiding
Copy link
Contributor Author

chrisbreiding commented Aug 2, 2019 •
edited
Loading

Fixed:

Screen Shot 2019-08-02 at 9 11 27 AM

Screen Shot 2019-08-02 at 9 37 23 AM

@chrisbreiding chrisbreiding changed the title Another layout issue in Desktop GUI More layout issues in Desktop GUI Aug 2, 2019
@chrisbreiding
Copy link
Contributor Author

I went through and watched all the tests, manually verifying the layout in various states, so these should be the last of the layout issues 🤞

@chrisbreiding chrisbreiding mentioned this issue Aug 2, 2019
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Aug 2, 2019
@chrisbreiding chrisbreiding mentioned this issue Aug 2, 2019
Closed
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 8, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 8, 2019

The code for this is done in cypress-io/cypress#4914, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane jennifer-shehane mentioned this issue Aug 14, 2019
Closed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisbreiding chrisbreiding

Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix more Desktop GUI layout issues cypress-io/cypress
1 participant
@chrisbreiding