Handle browser not found object better

[bahmutov]

v3.4.1 - a browser not found error does not understand that it gets an object, not a name

throwBrowserNotFound(nameOrPath, browsers)

throwBrowserNotFound = (browserName, browsers = []) ->
  names = _.map(browsers, "name").join(", ")
  debug("BROWSER_NOT_FOUND_BY_NAME %o available browser names %o", browserName, names)
  errors.throw("BROWSER_NOT_FOUND_BY_NAME", browserName, names)

  cypress:server:browsers selecting browser launcher for family electron-app +0ms
  cypress:server:browsers BROWSER_NOT_FOUND_BY_NAME { displayName: 'cypress-example-electron', family: 'electron-app', info: 'Electron.js app that supports the Cypress launcher', isChosen: true, majorVersion: '99', name: 'cypress-example-electron', path: '/Users/gleb/git/cypress-example-electron', version: '0.0.0', isHeaded: true, isHeadless: false } available browser names 'chrome, canary, cypress-example-electron'

[bahmutov]

oh, it is actually called from a different place, and should pass browser name. Simple to fix

if not browserLauncher = getBrowserLauncherByFamily(browser.family)
  return throwBrowserNotFound(browser, options.browsers)

in packages/server/lib/browsers/index.coffee

[Aa88s]

packages/server/lib/browsers/index.coffee

[Aa88s]

Issue with the server,browser support, and packing

[cypress-bot]

The code for this is done in cypress-io/cypress#4999, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.5.0.