Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for disabling screenshots in cypress.json #5029

Closed
Svish opened this issue Aug 23, 2019 · 3 comments · Fixed by #8083
Closed

Add configuration option for disabling screenshots in cypress.json #5029

Svish opened this issue Aug 23, 2019 · 3 comments · Fixed by #8083
Labels
good first issue Good for newcomers topic: screenshots 📸 type: feature New feature that does not currently exist

Comments

@Svish
Copy link

Svish commented Aug 23, 2019

To disable video, all I need to do is to add the following to my cypress.json file:

{
  "video": false
}

To disable screenshots on the other hand, I have to put this ugly code somewhere:

Cypress.Screenshot.defaults({
  screenshotOnRunFailure: false,
});

Can you please just add a simpler config for this so I can keep the global cypress test configuration in one place? E.g.

{
  "video": false,
  "screenshotOnRunFailure": false,
}

Cypress version: 3.4.1

@Svish Svish changed the title Add possibility to disable screenshots in cypress.json Add configuration option for disabling screenshots in cypress.json Aug 26, 2019
@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Jan 6, 2020
@jennifer-shehane jennifer-shehane added topic: screenshots 📸 type: feature New feature that does not currently exist good first issue Good for newcomers labels Jan 6, 2020
@harshitjuneja
Copy link

harshitjuneja commented Jan 18, 2020

@jennifer-shehane @Svish Can this be please assigned to me. Interested to work on this feature.

@jennifer-shehane
Copy link
Member

@harshitjuneja Feel free to open a PR - even one that is a work in progress is fine. Check out our contributing doc and ask us if you get stuck.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2020

Released in 4.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Aug 3, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 3, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers topic: screenshots 📸 type: feature New feature that does not currently exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants