Video process never exits - continues writing frames even after browser process killed

[jennifer-shehane]

Current behavior:

There are some circumstances where the video recording will continue writing even after the specfile is finished and the browser process is killed.

The log below is an example. The writing video frame and video stream drained logging goes on forever until the main CI process times out.

mochawesome Report JSON saved to /app/mochawesome-report/mochawesome_003.json

  cypress:server:video:frames writing video frame +112ms
  cypress:server:video:frames video stream drained +0ms

  (Results)

   ┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ 
   │  Tests:        6                                              │
   │  Passing:      4                                              │
   │  Failing:      1                                              │
   │  Pending:      1                                              │
   │  Skipped:      0                                              │
   │  Screenshots:  1                                              │
   │  Video:        true                                           │
   │  Duration:     1 minute, 9 seconds                            │
   │  Estimated:    43 seconds                                     │
   │  Spec Ran:     spec.js                                        │
   └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ 

  (Screenshots)

  - /app/cypress/screenshots/spec.js/Test (failed).png  (1280x720)

  cypress:server:run attempting to close the browser 
  cypress:server:browsers killing browser process +1m
  cypress:server:video:frames writing video frame +981ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video:frames writing video frame +144ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video capture stderr log { message: �[32m'frame= 1826 fps= 27 q=12.0 size=    7680kB time=00:01:12.08 bitrate= 872.8kbits/s dup=504 drop=0 speed=1.05x    ' } �[31m+1s
  cypress:server:video:frames writing video frame +100ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video:frames writing video frame +149ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video:frames writing video frame +150ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video:frames writing video frame +100ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video capture stderr log { message: 'frame= 1839 fps= 27 q=12.0 size=    7680kB time=00:01:12.60 bitrate= 866.6kbits/s dup=513 drop=0 speed=1.05x    ' } +483ms
  cypress:server:video:frames writing video frame +100ms
  cypress:server:video:frames video stream drained +1ms
  cypress:server:video:frames writing video frame +150ms
  cypress:server:video:frames video stream drained +0ms
  cypress:server:video:frames writing video frame +99ms

Desired behavior:

We should at the least have some sort of timeout so that the video recording doesn't hang forever.

Ideally we should fix this completely by ending the recording and compressing/uploading the video.

Steps to reproduce: (app code and test code)

That's a tough one! This was reported by another user, so I don't have a completely reproducible example.

Versions

Cypress 3.4.1
BuildKite CI
Linux Debian - 9.9
Electron 61.0.3163.100

[flotwig]

I wonder if switching Electron to record video via CDP would fix this issue: #4628 (not currently implemented for Electron)

[bahmutov]

Hehe that’s what we were talking in chat with Jennifer

…

Sent from my iPhone

On Oct 22, 2019, at 17:56, Zach Bloomquist ***@***.***> wrote:  I wonder if switching Electron to record video via CDP would fix this issue: #4628 — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

[jennifer-shehane]

@flotwig Yeah, I hope so. I will followup with them to see if there's improvement once 3.5.0 is out. Unfortunately it's an issue that is not consistent, so we'll see.

[TheWanderingWalnut]

We've been seeing this as well, where Cypress will put out 15+ minute files after a 20s test or so, as it only seems to stop recording once the session is killed. I have tried reproducing it in various ways, even cross-platform, and for me it is only happening in our specific tests (not on the example project with a similar set of code).

I have only seen this behaviour myself on Mac OSX using Cypress v3.4.1 and 3.5.0, though it is incredibly intermittent and hard to track.

There was a bug post a little while back about pending network requests possibly causing it to hang, though I was unable to prove or disprove this theory in my testing, as it seems to fail whether or not there are pending network requests.

[jennifer-shehane]

@flotwig This issue is still persisting using 3.5.0. Any guidance on what to try to keep this issue from happening would be appreciated.

[djaromir]

Same thing happens to me with cypress 3.6.0 and 3.4.1, Win10
When I set video to false, the test run never exits anyway, finishes with:
cypress:server:run attempting to close the browser +8s cypress:server:browsers killing browser process +8s
And hangs

there are no:
cypress:server:video:frames video stream drained +0ms cypress:server:video:frames writing video frame +99ms

[jennifer-shehane]

Since this issue hasn't had activity in a while, we'll close the issue until we can confirm this is still happening. Please comment if there is new information to provide concerning the original issue and we'd be happy to reopen.