Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account the search pattern when running all specs in the interactive mode #6581

Closed
bahmutov opened this issue Feb 27, 2020 · 7 comments · Fixed by #8007
Closed

Take into account the search pattern when running all specs in the interactive mode #6581

bahmutov opened this issue Feb 27, 2020 · 7 comments · Fixed by #8007
Assignees
@bahmutov
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: feature New feature that does not currently exist

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Feb 27, 2020 •
edited by sync-by-unito bot
Loading

Our users are asking us sometimes to run some specs when using the interactive mode. I think the simplest way we could make them happy is to use the search pattern when the user clicks "Run All Specs" button.
@bahmutov bahmutov added the pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory label Feb 27, 2020
@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Feb 28, 2020
@jennifer-shehane jennifer-shehane added priority: low 🎗 type: user experience Improvements needed for UX and removed stage: proposal 💡 No work has been done of this issue labels Feb 28, 2020
@jennifer-shehane
Copy link
Member

Duplicate of #3607

Albeit a very different suggested implementation - the goal of that request is the same, to run a 'subset' of spec files during cypress open.

@jennifer-shehane jennifer-shehane added type: duplicate This issue or pull request already exists and removed pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory priority: low 🎗 type: user experience Improvements needed for UX labels Feb 28, 2020
@jennifer-shehane jennifer-shehane mentioned this issue Feb 28, 2020
Open
@samtsai
Copy link
Contributor

samtsai commented Jul 15, 2020

Duplicate of #3607

Albeit a very different suggested implementation - the goal of that request is the same, to run a 'subset' of spec files during cypress open.

I've tried the filter and then "Run All Specs" but it seems to just run all the specs ignoring the filter.

@jennifer-shehane
Copy link
Member

@samtsai Yes, this feature does not exist. #3607 is a request for this feature and has not been released.

@samtsai
Copy link
Contributor

samtsai commented Jul 16, 2020

@samtsai Yes, this feature does not exist. #3607 is a request for this feature and has not been released.

Thanks for the clarification @jennifer-shehane , keep up the good work!

@jennifer-shehane
Copy link
Member

Reopening as I think this doesn't exactly cover the use cases of #3607.

@jennifer-shehane jennifer-shehane added type: feature New feature that does not currently exist and removed type: duplicate This issue or pull request already exists labels Jul 28, 2020
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Jul 28, 2020
@jennifer-shehane jennifer-shehane added the pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory label Jul 28, 2020
@bahmutov bahmutov mentioned this issue Jul 28, 2020
Merged
10 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Jul 28, 2020
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Jul 29, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 30, 2020

The code for this is done in cypress-io/cypress#8007, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2020

Released in 4.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 3, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bahmutov bahmutov

Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: feature New feature that does not currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: run only filtered specs cypress-io/cypress
3 participants
@samtsai @jennifer-shehane @bahmutov