cy.server whitelist behaves as blacklist

[alex-golubtsov]

Current behavior:

Currently whitelist option for cy.server() actually works as blacklist due to this line
https://github.com/cypress-io/cypress/blob/master/packages/driver/src/cypress/server.coffee#L236

In other words:

cy.server({ whitelist: () => true })

will ignore any request

and

cy.server({ whitelist: () => false})

will catch all requests

Desired behavior:

Exactly opposite

cy.server({ whitelist: () => true })

should catch all requests

and

cy.server({ whitelist: () => false})

should ignore any request

Test code to reproduce

cy.server()
cy.route(<any route>)

Versions

4.1.0, also reproducible in master
win10, chrome

[jennifer-shehane]

yeeeaaah...I can see this. This would require a breaking change.

[cypress-bot]

The code for this is done in cypress-io/cypress#7782, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[jennifer-shehane]

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v5.0.0, please open a new issue.