Assertions failures on DOM elements show unexpected diffs when they weren't retried

[chrisbreiding]

Current behavior:

When an assertion involving a dom element retried fails, it shows a diff that includes an ugly dom object.

When an assertion involving a DOM element was NOT retried, the assertion would include the very ugly serialized object in stdout reporters.

Note that this doesn't happen if the assertion is retried (with cy.should()).

Desired behavior:

Failing dom assertions should never show a serialized DOM object diff.

Test code to reproduce

it('dom - fails without retry', () => {
  cy.get('body').then(($body) => {
    expect($body).to.have.class('foo')
  })
})

Versions

Cypress 4.1.0

[cypress-bot]

The code for this is done in cypress-io/cypress#6467, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

The code for this is done in cypress-io/cypress#6724, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 4.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.3.0, please open a new issue.