Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update error message for new error thrown when free plan limit exceeded #8409

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Aug 26, 2020

User Changelog

  • cypress run when recording will no longer exit and stop recording when exceeding the number of test recordings on a free plan. The stdout will instead display a warning message.

Additional Details

  • I decided not to be explicit about the consequences of exceeding the free limit, as I don’t think we should hard code this into the Test Runner so that we have flexibility to change this on the API side. (Meaning, I am not explicitly saying that parallelization is disabled now).
  • I also tweaked the existing language of exceeding plans in general.

How has the user experience changed?

Before

Free plans exceeds monthly limit

65aee43f-16d5-4d4a-91b9-e965e67c4504

Paid plan exceeds monthly limit

You've exceeded the limit of test recordings under your current billing plan this month. The limit is 500 test recordings.

To upgrade your account, please visit your billing to upgrade to another billing plan.

https://on.cypress.io/dashboard/organizations/org-id-1234/billing

Free plan in grace period exceeds monthly limit

You've exceeded the limit of test recordings under your free billing plan this month. The limit is 500 private test recordings.

Your plan is now in a grace period, which means your tests will still be recorded until 2999-12-31. Please upgrade your plan to continue recording tests on the Cypress Dashboard in the future.

https://on.cypress.io/dashboard/organizations/org-id-1234/billing

After

Free plans exceeds monthly limit

Screen Shot 2020-08-26 at 1 42 25 PM

Paid plan exceeds monthly limit

Screen Shot 2020-08-26 at 1 42 06 PM

Free plan in grace period exceeds monthly limit
Screen Shot 2020-08-26 at 1 41 45 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 26, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 26, 2020



Test summary

8137 0 108 3


Run details

Project cypress
Status Passed
Commit 88e58b2
Started Aug 26, 2020 7:21 AM
Ended Aug 26, 2020 7:32 AM
Duration 11:00 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane changed the title Update error message for new error thrown when free plan limit exceeded fix: Update error message for new error thrown when free plan limit exceeded Aug 26, 2020
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jennifer-shehane jennifer-shehane merged commit eb28cff into develop Aug 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 1, 2020

Released in 5.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 1, 2020
@emilyrohrbough emilyrohrbough deleted the TR-292 branch August 1, 2024 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants