From b895b2d1c3ef1c6bdb5d021dfd9974dca52a9392 Mon Sep 17 00:00:00 2001 From: David Munechika Date: Mon, 7 Mar 2022 12:00:57 -0500 Subject: [PATCH 1/2] fix: strip ansi for chrome web security error --- packages/server/lib/project-base.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/server/lib/project-base.ts b/packages/server/lib/project-base.ts index c9eb60b855ef..7bab674d5cbd 100644 --- a/packages/server/lib/project-base.ts +++ b/packages/server/lib/project-base.ts @@ -30,6 +30,7 @@ import * as settings from './util/settings' import specsUtil from './util/specs' import system from './util/system' import Watchers from './watchers' +import stripAnsi from 'strip-ansi' import type { LaunchArgs } from './open_project' @@ -704,7 +705,7 @@ export class ProjectBase extends EE { return { ...browser, - warning: browser.warning || errors.getMsgByType('CHROME_WEB_SECURITY_NOT_SUPPORTED', browser.name), + warning: browser.warning || stripAnsi(errors.getMsgByType('CHROME_WEB_SECURITY_NOT_SUPPORTED', browser.name)), } }) } From 53fd8909c23d40e1288dc4eabdbe4d882f42547b Mon Sep 17 00:00:00 2001 From: David Munechika Date: Mon, 7 Mar 2022 12:18:13 -0500 Subject: [PATCH 2/2] fix unit test --- packages/server/test/unit/project_spec.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/server/test/unit/project_spec.js b/packages/server/test/unit/project_spec.js index 7cd5321d41c1..e149cbd3891a 100644 --- a/packages/server/test/unit/project_spec.js +++ b/packages/server/test/unit/project_spec.js @@ -1,5 +1,3 @@ -const { theme } = require('@packages/errors/src/errTemplate') - require('../spec_helper') const mockedEnv = require('mocked-env') @@ -248,7 +246,7 @@ describe('lib/project-base', () => { family: 'some-other-family', name: 'some-other-name', warning: `\ -Your project has set the configuration option: ${theme.yellow('chromeWebSecurity')} to ${theme.blue('false')} +Your project has set the configuration option: chromeWebSecurity to false This option will not have an effect in Some-other-name. Tests that rely on web security being disabled will not run as expected.\ `,