From 7ef8f9c8f3350bff152fbe609fe6ce93bdd89c2a Mon Sep 17 00:00:00 2001 From: Vinicius Pietscher Date: Sun, 5 Jun 2022 11:23:41 -0400 Subject: [PATCH 1/8] fix: add padding --- packages/launchpad/src/global/GlobalPage.vue | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/launchpad/src/global/GlobalPage.vue b/packages/launchpad/src/global/GlobalPage.vue index b6b853d8ebf2..b5a786a8dfa3 100644 --- a/packages/launchpad/src/global/GlobalPage.vue +++ b/packages/launchpad/src/global/GlobalPage.vue @@ -12,7 +12,9 @@ > {{ t('globalPage.recentProjectsHeader') }} -
+
Date: Sun, 5 Jun 2022 14:48:37 -0400 Subject: [PATCH 2/8] fix: add padding (#21724) --- packages/launchpad/src/global/GlobalPage.cy.tsx | 7 +++++++ packages/launchpad/src/global/GlobalPage.vue | 7 ++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/packages/launchpad/src/global/GlobalPage.cy.tsx b/packages/launchpad/src/global/GlobalPage.cy.tsx index d70b0f47186c..a2ef0c8020a9 100644 --- a/packages/launchpad/src/global/GlobalPage.cy.tsx +++ b/packages/launchpad/src/global/GlobalPage.cy.tsx @@ -68,6 +68,13 @@ describe('', { viewportHeight: 900, viewportWidth: 1200 }, () => { it('renders projects', () => { cy.findByText(testProject).should('be.visible') cy.findByText(testProjectPath).should('be.visible') + // validate that there is some padding on the bottom + cy.get('[data-cy="project-card"]') + .parent() + .invoke('outerHeight') + .then((parentHeight) => { + cy.get('[data-cy="project-card"]').invoke('outerHeight').should('be.lt', parentHeight) + }) }) it('can filter down the projects by name', () => { diff --git a/packages/launchpad/src/global/GlobalPage.vue b/packages/launchpad/src/global/GlobalPage.vue index b5a786a8dfa3..e4565bfb1d21 100644 --- a/packages/launchpad/src/global/GlobalPage.vue +++ b/packages/launchpad/src/global/GlobalPage.vue @@ -12,9 +12,10 @@ > {{ t('globalPage.recentProjectsHeader') }} -
+
Date: Sun, 5 Jun 2022 18:39:14 -0400 Subject: [PATCH 3/8] Update packages/launchpad/src/global/GlobalPage.cy.tsx Co-authored-by: Mark Noonan --- packages/launchpad/src/global/GlobalPage.cy.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/launchpad/src/global/GlobalPage.cy.tsx b/packages/launchpad/src/global/GlobalPage.cy.tsx index a2ef0c8020a9..7e2d4ca79a38 100644 --- a/packages/launchpad/src/global/GlobalPage.cy.tsx +++ b/packages/launchpad/src/global/GlobalPage.cy.tsx @@ -74,6 +74,7 @@ describe('', { viewportHeight: 900, viewportWidth: 1200 }, () => { .invoke('outerHeight') .then((parentHeight) => { cy.get('[data-cy="project-card"]').invoke('outerHeight').should('be.lt', parentHeight) + cy.percySnapshot() }) }) From 9c225386c78659f0865c3c871634628ed6673b01 Mon Sep 17 00:00:00 2001 From: Vinicius Pietscher Date: Wed, 8 Jun 2022 16:22:17 -0400 Subject: [PATCH 4/8] no longer necessary for this fix --- packages/launchpad/src/global/GlobalPage.cy.tsx | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/launchpad/src/global/GlobalPage.cy.tsx b/packages/launchpad/src/global/GlobalPage.cy.tsx index 7e2d4ca79a38..d70b0f47186c 100644 --- a/packages/launchpad/src/global/GlobalPage.cy.tsx +++ b/packages/launchpad/src/global/GlobalPage.cy.tsx @@ -68,14 +68,6 @@ describe('', { viewportHeight: 900, viewportWidth: 1200 }, () => { it('renders projects', () => { cy.findByText(testProject).should('be.visible') cy.findByText(testProjectPath).should('be.visible') - // validate that there is some padding on the bottom - cy.get('[data-cy="project-card"]') - .parent() - .invoke('outerHeight') - .then((parentHeight) => { - cy.get('[data-cy="project-card"]').invoke('outerHeight').should('be.lt', parentHeight) - cy.percySnapshot() - }) }) it('can filter down the projects by name', () => { From 08af079d80bf39d48831f1f8f4f9756f26000387 Mon Sep 17 00:00:00 2001 From: Vinicius Pietscher Date: Wed, 8 Jun 2022 16:23:37 -0400 Subject: [PATCH 5/8] no longer necessary padding will be added to Main.vue --- packages/launchpad/src/global/GlobalPage.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/launchpad/src/global/GlobalPage.vue b/packages/launchpad/src/global/GlobalPage.vue index e4565bfb1d21..c3f6abb393b2 100644 --- a/packages/launchpad/src/global/GlobalPage.vue +++ b/packages/launchpad/src/global/GlobalPage.vue @@ -13,7 +13,6 @@ {{ t('globalPage.recentProjectsHeader') }}
Date: Wed, 8 Jun 2022 16:24:22 -0400 Subject: [PATCH 6/8] add bottom padding --- packages/launchpad/src/Main.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/launchpad/src/Main.vue b/packages/launchpad/src/Main.vue index 364871230376..78db559fd6c4 100644 --- a/packages/launchpad/src/Main.vue +++ b/packages/launchpad/src/Main.vue @@ -12,7 +12,7 @@ />
Date: Wed, 8 Jun 2022 16:25:11 -0400 Subject: [PATCH 7/8] add percy test --- packages/launchpad/cypress/e2e/global-mode.cy.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/launchpad/cypress/e2e/global-mode.cy.ts b/packages/launchpad/cypress/e2e/global-mode.cy.ts index 991bb5219e15..0b1568999499 100644 --- a/packages/launchpad/cypress/e2e/global-mode.cy.ts +++ b/packages/launchpad/cypress/e2e/global-mode.cy.ts @@ -88,6 +88,8 @@ describe('Launchpad: Global Mode', () => { expect(card).to.contain(projectList[index]) expect(card).to.contain(`cy-projects${sep}${projectList[index]}`) }) + + cy.percySnapshot() } it('shows the recent projects list sorted by most-recently opened', () => { From 4df3b792527f7c7c21ed7636e493522750ffbae8 Mon Sep 17 00:00:00 2001 From: Mark Noonan Date: Tue, 21 Jun 2022 23:33:18 -0400 Subject: [PATCH 8/8] move percy snapshot out of helper function --- packages/launchpad/cypress/e2e/global-mode.cy.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/launchpad/cypress/e2e/global-mode.cy.ts b/packages/launchpad/cypress/e2e/global-mode.cy.ts index 0b1568999499..c76cc80dbfab 100644 --- a/packages/launchpad/cypress/e2e/global-mode.cy.ts +++ b/packages/launchpad/cypress/e2e/global-mode.cy.ts @@ -88,14 +88,14 @@ describe('Launchpad: Global Mode', () => { expect(card).to.contain(projectList[index]) expect(card).to.contain(`cy-projects${sep}${projectList[index]}`) }) - - cy.percySnapshot() } it('shows the recent projects list sorted by most-recently opened', () => { const projectList = ['todos', 'ids', 'cookies', 'plugin-empty'] setupAndValidateProjectsList(projectList) + + cy.percySnapshot() }) it('takes user to the next step when clicking on a project card', () => {