-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't inherit default message for request logging #28411
Conversation
_Released 12/5/2023 (PENDING)_ | ||
|
||
**Bugfixes:** | ||
- Fixed an issue where request logging would default the `message` to the `args` of the currently running command even though those `args` would not apply to the request log and are not displayed. If the `args` are sufficiently large (e.g. when running the `cy.task` from the [code-coverage](https://github.com/cypress-io/code-coverage/) plugin) there could be performance/memory implications. Addressed in [#28411](https://github.com/cypress-io/cypress/pull/28411). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little confusing. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to suggestions :)
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
During
fetch/xhr
request logging, we don’t set the log.message here which means when we create the message, we take the args of the current command as the message which is incorrect for a request log since it’s not related in any way to the current command.The message of the current command can be very large at times (e.g. when the
cy.task
of thecode-coverage
plugin is running) which may have performance and memory implications both in the app and when recording for Test Replay.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?